Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more features to TDR window #717

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

EnPassant123
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • [] Bugfix
  • [*] Feature
  • [] Code style update (formatting, renaming)
  • [] Refactoring (no functional changes, no API changes)
  • [] Build-related changes
  • [] Documentation content changes
  • [] Other (please describe):

What is the current behavior?

The user is only allowed to plot the magnitude of the impedance (or |Z|)

What is the new behavior?

The user is now allowed to select from a menu whether they want to plot |Z|, S11, or VSWR. This would allow the user to display their data in a different format

Does this introduce a breaking change?

  • [] Yes
  • [*] No

Other information

Here is what everything looks like now:
image

image

image

Maybe in the future you can plot real/imaginary?

Fix bug with setuptools_scm not being able to find .git
Fix math with TDR
Allow for plotting of S11 and VSWR
Allow user to select |Z|, VSWR, or S11
@EnPassant123 EnPassant123 requested a review from zarath as a code owner October 9, 2024 06:31
Copy link
Collaborator

@zarath zarath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission

@zarath zarath merged commit 3614939 into NanoVNA-Saver:main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants